notevil fdf7330523 BUG-RACE-01 : document Phase 2 listener registration ordering ...

Reviewer flagged race between AnimationManager parsing (LIVING_MOTION_CODEC.getOrThrow)
and LivingMotionReloadListener.apply(). Investigation confirmed :
- AnimationManager is NOT currently registered as a reload listener (Phase 2 pending)
- Forge 1.20.1 has no PreparableReloadListener.getDependencies() — that's a Fabric/NeoForge API
- 1.20.1 ordering mechanism = registration list order via SimpleReloadInstance.barrier.wait()

Fix : preventive comment in AnimationManager.apply() documenting that
when Phase 2 wires this listener, it MUST be registered AFTER
LivingMotionReloadListener / ArmatureReloadListener / PoseTypeReloadListener
in TiedUpMod.ForgeEvents.onAddReloadListeners + V2ClientSetup.onRegisterReloadListeners.

Drive-by : add docs.tar.gz to .gitignore (artist export bundle).

No actionable race today — pure documentation hardening.

2026-04-26 22:07:18 +02:00

486 B

Raw Blame History

View Raw