feature/d01-component-system #5

NotEvil · 2026-04-14T00:53:50Z

NotEvil commented

2026-04-14 00:53:50 +00:00

No description provided.

NotEvil added 20 commits 2026-04-14 00:53:51 +00:00

feat(D-01): add IItemComponent interface for data-driven item behaviors edfc3c6506

feat(D-01): add ComponentType enum with stub component classes b8a0d839f5

feat(D-01): add ComponentHolder container for item components 1b70041c36

feat(D-01): parse component configs from item JSON definitions 750be66d80

Add componentConfigs field (Map<ComponentType, JsonObject>) to
DataDrivenItemDefinition record. The parser now reads an optional
"components" JSON block, resolves each key via ComponentType.fromKey(),
and stores the raw JsonObject configs for later instantiation.

feat(D-01): instantiate ComponentHolder per item definition on reload a781dad597

Add a parallel COMPONENT_HOLDERS volatile cache to DataDrivenItemRegistry,
rebuilt from raw componentConfigs every time definitions are loaded via
reload() or mergeAll(). Cleared alongside DEFINITIONS in clear().

Two accessor methods allow looking up a ComponentHolder by ItemStack
(reads tiedup_item_id NBT) or by ResourceLocation directly.

feat(D-01): delegate DataDrivenBondageItem lifecycle to components 3a1f401ccf

Override onEquipped(), onUnequipped(), and canUnequip() in
DataDrivenBondageItem to delegate to the item's ComponentHolder.
The canUnequip() override preserves the existing lock check from
AbstractV2BondageItem via super.canUnequip().

Add a static getComponent() helper for external code to retrieve
a typed component from any data-driven item stack.

feat(D-01): implement LockableComponent with configurable lock resistance caeb4469b1

feat(D-01): implement ResistanceComponent, improve stack-aware resistance lookup 84f4c3a53f

feat(D-01): implement GaggingComponent with comprehension and range 231522c68e

feat(D-01): add test_component_gag.json demonstrating component system dbacef66d5

JSON item using all 3 implemented components: lockable (lock_resistance: 200),
resistance (base: 80), and gagging (comprehension: 0.15, range: 8.0).

fix(D-01): atomic snapshot for registry to prevent torn reads (BUG-001) 1327e3bfc3

Replace two separate volatile fields (DEFINITIONS, COMPONENT_HOLDERS)
with a single RegistrySnapshot record swapped atomically. This prevents
race conditions where a reader thread could see new definitions paired
with stale/empty component holders between the two volatile writes.

fix(D-01): remove dead onWornTick() until V2 tick mechanism exists (BUG-002) bb209bcd8e

Remove onWornTick() from IItemComponent (default method) and
ComponentHolder (aggregate method). No V2 tick caller invokes these,
so they create a broken contract. Can be re-added when a tick
mechanism is implemented.

fix(D-01): wire LockableComponent.lockResistance via getItemLockResistance() (BUG-003) 456335e0dd

- Remove redundant blocksUnequip() from LockableComponent since
  AbstractV2BondageItem.canUnequip() already checks ILockable.isLocked()
- Add DataDrivenBondageItem.getItemLockResistance(ItemStack) that reads
  the per-item lock resistance from the LockableComponent, falling back
  to the global config value when absent

fix(D-01): warn on non-object component config, deep-copy configs (RISK-001, RISK-002) bb589d44f8

- Deep-copy JsonObject configs via deepCopy() before storing in the
  definition to prevent external mutation of the parsed JSON tree
- Log a warning when a component config value is not a JsonObject,
  making misconfigured JSON easier to diagnose

fix(D-01): clamp component config values to valid ranges (RISK-003) 3a81bb6e12

- LockableComponent: lock_resistance clamped to >= 0
- ResistanceComponent: base resistance clamped to >= 0
- GaggingComponent: comprehension clamped to [0.0, 1.0], range to >= 0.0

Prevents nonsensical negative values from malformed JSON configs.

fix(D-01): compact constructor defaults null componentConfigs to empty (RISK-004) bfcc20d242

Add compact constructor to DataDrivenItemDefinition that defaults null
componentConfigs to Map.of(). This makes the field guaranteed non-null,
allowing removal of null checks in hasComponent() and
DataDrivenItemRegistry.buildComponentHolders().

fix(D-01): pre-built map for O(1) ComponentType.fromKey() lookup (RISK-005) dcc8493e5e

Replace linear values() scan with a static unmodifiable HashMap lookup.
While only 3 entries currently exist, this establishes the correct
pattern for when more component types are added.

feat(D-01): implement 5 remaining components (blinding, shock, gps, choking, adjustable) 185ac63a44

fix(D-01): synchronize reload paths and capture snapshot locally (RISK-001, RISK-002) 90bc890b95

docs: add components section to ARTIST_GUIDE.md 7bd840705a

Documents the 8 available gameplay components (lockable, resistance,
gagging, blinding, shock, gps, choking, adjustable) with config fields,
examples (GPS shock collar, adjustable blindfold), and usage tips.

NotEvil merged commit fa4c332a10 into develop

2026-04-14 00:54:17 +00:00

NotEvil referenced this issue from a commit

2026-04-14 00:54:18 +00:00

Merge pull request 'feature/d01-component-system' (#5) from feature/d01-component-system into develop

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NotEvil/TiedUp-#5