chore/audit-uc02-roomtheme-datadriven #14

NotEvil · 2026-04-16T00:38:41Z

NotEvil commented

2026-04-16 00:38:41 +00:00

No description provided.

NotEvil added 6 commits 2026-04-16 00:38:42 +00:00

feat(UC-02): data-driven room theme infrastructure (Phase 1+2) 69f52eacf3

- BlockPalette: weighted random block selection with condition variants
- RoomThemeDefinition: immutable record with wallBlock/floorBlock/etc convenience API
- DecorationConfig: positioned block records for theme-specific decorations
- RoomThemeRegistry: volatile atomic snapshot + pickRandom(weight-based)
- RoomThemeParser: JSON parsing with BlockStateParser + random_property expansion
- RoomThemeReloadListener: scans data/<ns>/tiedup_room_themes/*.json
- Register listener in TiedUpMod.onAddReloadListeners()

feat(UC-02): data-driven room themes — 6 JSON + consumer migration + cleanup 3aaf92b788

Phase 3: Extract 6 themes into JSON (oubliette, inferno, crypt, ice, sculk, sandstone)
Phase 4: Migrate HangingCagePiece to use RoomThemeRegistry.pickRandomOrFallback()
  - Move 7 shared static methods from RoomTheme into HangingCagePiece
  - Replace per-enum placeDecorations() with generic DecorationConfig-based placement
Phase 5: Delete RoomTheme.java (-1368L)

fix(UC-02): QA review — crypt bottom_row + ice decorations fidelity 706172fb9a

- BUG-001: CRYPT bottom_row had unreachable mossy_stone_bricks (same f variable
  makes mossy_cobblestone guard trigger first). Fixed weights: 0.20/0.10/0.70
- BUG-003: ICE ceiling ice stalactites (y_offset=10) were missing from JSON
- BUG-002: ICE snow corner layers use middle value (3) as compromise since
  DecorationConfig.PositionedBlock doesn't support random_property

fix(UC-02): arch review — furniture x/z offsets + ceiling chain fidelity 6d9d6b4b81

- Add x_offset/z_offset to PositionedBlock for multi-block furniture clusters
- Furniture items now spread across 2-3 positions (matching original Java code)
- Offsets multiplied by inward direction for correct corner orientation
- Fix has_ceiling_chain: only oubliette has ceiling chains (was true for all 6)
- Fix firstCornerSpecial: oubliette cauldron uses x/z offset +1 (inward diagonal)
- Update parser to read x_offset/z_offset (defaults to 0)

fix(UC-02): clean theme IDs — strip directory prefix and .json suffix 8823c671d7

RISK-003: Definition IDs were "tiedup:tiedup_room_themes/oubliette.json"
instead of clean "tiedup:oubliette". Now derived from filename only.

fix(UC-02): LOW review items — anchored path strip + corner offset doc 6d56024c7e

- Use substring instead of replace for path cleanup (anchored, no double-strip risk)
- Document that corner_decorations ignores x/z offsets (by design)

NotEvil merged commit bce0598059 into develop

2026-04-16 00:38:59 +00:00

NotEvil referenced this issue from a commit

2026-04-16 00:39:00 +00:00

Merge pull request 'chore/audit-uc02-roomtheme-datadriven' (#14) from chore/audit-uc02-roomtheme-datadriven into develop

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NotEvil/TiedUp-#14