Reviewer flagged race between AnimationManager parsing (LIVING_MOTION_CODEC.getOrThrow)
and LivingMotionReloadListener.apply(). Investigation confirmed :
- AnimationManager is NOT currently registered as a reload listener (Phase 2 pending)
- Forge 1.20.1 has no PreparableReloadListener.getDependencies() — that's a Fabric/NeoForge API
- 1.20.1 ordering mechanism = registration list order via SimpleReloadInstance.barrier.wait()
Fix : preventive comment in AnimationManager.apply() documenting that
when Phase 2 wires this listener, it MUST be registered AFTER
LivingMotionReloadListener / ArmatureReloadListener / PoseTypeReloadListener
in TiedUpMod.ForgeEvents.onAddReloadListeners + V2ClientSetup.onRegisterReloadListeners.
Drive-by : add docs.tar.gz to .gitignore (artist export bundle).
No actionable race today — pure documentation hardening.
C-01 : GENERAL_ANIMATION_TRANSITION_TIME was int 6 while all consumers
expect a float transitionTime in seconds — 6s gave inter-animation
transitions of 120 ticks. Change to float 0.15F (3 ticks).
C-02 : JointMaskReloadListener was never registered, leaving
AnimationSubFileReader callers at lines 170/182/184 to receive null
from getNoneMask()/getJointMaskEntry() with no data loaded. Register
it in V2ClientSetup at LOW priority so it fires after the GLB cache
clear and alongside the other bondage client reload listeners.
M-03 : ASSETS_NEEDED.md JSON example already corrected in the earlier
doc-keeper pass (Torso=7, Chest=8, etc.).
Drive-by: add logs/ to .gitignore — the runClient logs were
accidentally tracked.
