From f4aae9adb7f104a4bf30d26ea0d2a042c30d2249 Mon Sep 17 00:00:00 2001 From: notevil Date: Thu, 23 Apr 2026 04:41:48 +0200 Subject: [PATCH] Audit-1 : fix transition time + JointMaskReloadListener MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit C-01 : GENERAL_ANIMATION_TRANSITION_TIME was int 6 while all consumers expect a float transitionTime in seconds — 6s gave inter-animation transitions of 120 ticks. Change to float 0.15F (3 ticks). C-02 : JointMaskReloadListener was never registered, leaving AnimationSubFileReader callers at lines 170/182/184 to receive null from getNoneMask()/getJointMaskEntry() with no data loaded. Register it in V2ClientSetup at LOW priority so it fires after the GLB cache clear and alongside the other bondage client reload listeners. M-03 : ASSETS_NEEDED.md JSON example already corrected in the earlier doc-keeper pass (Torso=7, Chest=8, etc.). Drive-by: add logs/ to .gitignore — the runClient logs were accidentally tracked. --- .gitignore | 1 + src/main/java/com/tiedup/remake/rig/TiedUpRigConstants.java | 4 ++-- src/main/java/com/tiedup/remake/v2/client/V2ClientSetup.java | 5 ++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 86a5f23..c16f1ed 100644 --- a/.gitignore +++ b/.gitignore @@ -40,6 +40,7 @@ package-lock.json # Build logs build_output.log +logs/ # OS files .DS_Store diff --git a/src/main/java/com/tiedup/remake/rig/TiedUpRigConstants.java b/src/main/java/com/tiedup/remake/rig/TiedUpRigConstants.java index b1225fc..67ec9af 100644 --- a/src/main/java/com/tiedup/remake/rig/TiedUpRigConstants.java +++ b/src/main/java/com/tiedup/remake/rig/TiedUpRigConstants.java @@ -46,8 +46,8 @@ public final class TiedUpRigConstants { /** Durée d'un tick MC en secondes (20 TPS). */ public static final float A_TICK = 1.0F / 20.0F; - /** Durée de transition inter-animation par défaut (en ticks). */ - public static final int GENERAL_ANIMATION_TRANSITION_TIME = 6; + /** Durée de transition inter-animation par défaut (en secondes — 0.15s = 3 ticks). */ + public static final float GENERAL_ANIMATION_TRANSITION_TIME = 0.15F; /** Nombre max de joints supportés par une armature (limite matrice pool). */ public static final int MAX_JOINTS = 128; diff --git a/src/main/java/com/tiedup/remake/v2/client/V2ClientSetup.java b/src/main/java/com/tiedup/remake/v2/client/V2ClientSetup.java index 8ed3b06..07a0f02 100644 --- a/src/main/java/com/tiedup/remake/v2/client/V2ClientSetup.java +++ b/src/main/java/com/tiedup/remake/v2/client/V2ClientSetup.java @@ -116,8 +116,11 @@ public class V2ClientSetup { ) { event.registerReloadListener(new DataDrivenItemReloadListener()); event.registerReloadListener(new GlbValidationReloadListener()); + event.registerReloadListener( + new com.tiedup.remake.rig.anim.client.property.JointMaskReloadListener() + ); TiedUpMod.LOGGER.info( - "[V2ClientSetup] Data-driven item + GLB validation reload listeners registered" + "[V2ClientSetup] Data-driven item + GLB validation + joint mask reload listeners registered" ); }