From 647894508d86fccc0a5cdd12890db55559b6d9bb Mon Sep 17 00:00:00 2001 From: notevil Date: Thu, 23 Apr 2026 04:46:22 +0200 Subject: [PATCH] Audit-1 review : fix stale '6 ticks' comment + track NONE_MASK null MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reviewer flagged two MEDIUM cosmetic items : - SMELL-001 : TiedUpAnimationRegistry:97 comment still said '6 ticks' — updated to '0.15s = 3 ticks' to match the new constant. - SMELL-002 : JointMaskReloadListener.getNoneMask() can still return null if a resource pack omits tiedup:none. Call sites tolerate null today; logged in PHASE0_DEGRADATIONS for a Phase 3 fallback JSON + warn log. --- .../java/com/tiedup/remake/rig/TiedUpAnimationRegistry.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/tiedup/remake/rig/TiedUpAnimationRegistry.java b/src/main/java/com/tiedup/remake/rig/TiedUpAnimationRegistry.java index 33f936b..50da17f 100644 --- a/src/main/java/com/tiedup/remake/rig/TiedUpAnimationRegistry.java +++ b/src/main/java/com/tiedup/remake/rig/TiedUpAnimationRegistry.java @@ -94,7 +94,7 @@ public final class TiedUpAnimationRegistry { } try { - // transitionTime=GENERAL (6 ticks) + isRepeat=true + registryName + + // transitionTime=GENERAL (0.15s = 3 ticks) + isRepeat=true + registryName + // armature=BIPED. L'ordre match le ctor DirectStaticAnimation(float, boolean, ResourceLocation, AssetAccessor). CONTEXT_STAND_IDLE = new DirectStaticAnimation( TiedUpRigConstants.GENERAL_ANIMATION_TRANSITION_TIME,