Refactor V2 animation, furniture, and GLTF rendering
Broad consolidation of the V2 bondage-item, furniture-entity, and
client-side GLTF pipeline.
Parsing and rendering
- Shared GLB parsing helpers consolidated into GlbParserUtils
(accessor reads, weight normalization, joint-index clamping,
coordinate-space conversion, animation parse, primitive loop).
- Grow-on-demand Matrix4f[] scratch pool in GltfSkinningEngine and
GltfLiveBoneReader — removes per-frame joint-matrix allocation
from the render hot path.
- emitVertex helper dedups three parallel loops in GltfMeshRenderer.
- TintColorResolver.resolve has a zero-alloc path when the item
declares no tint channels.
- itemAnimCache bounded to 256 entries (access-order LRU) with
atomic get-or-compute under the map's monitor.
Animation correctness
- First-in-joint-order wins when body and torso both map to the
same PlayerAnimator slot; duplicate writes log a single WARN.
- Multi-item composites honor the FullX / FullHeadX opt-in that
the single-item path already recognized.
- Seat transforms converted to Minecraft model-def space so
asymmetric furniture renders passengers at the correct offset.
- GlbValidator: IBM count / type / presence, JOINTS_0 presence,
animation channel target validation, multi-skin support.
Furniture correctness and anti-exploit
- Seat assignment synced via SynchedEntityData (server is
authoritative; eliminates client-server divergence on multi-seat).
- Force-mount authorization requires same dimension and a free
seat; cross-dimension distance checks rejected.
- Reconnection on login checks for seat takeover before re-mount
and force-loads the target chunk for cross-dimension cases.
- tiedup_furniture_lockpick_ctx carries a session UUID nonce so
stale context can't misroute a body-item lockpick.
- tiedup_locked_furniture survives death without keepInventory
(Forge 1.20.1 does not auto-copy persistent data on respawn).
Lifecycle and memory
- EntityCleanupHandler fans EntityLeaveLevelEvent out to every
per-entity state map on the client.
- DogPoseRenderHandler re-keyed by UUID (stable across dimension
change; entity int ids are recycled).
- PetBedRenderHandler, PlayerArmHideEventHandler, and
HeldItemHideHandler use receiveCanceled + sentinel sets so
Pre-time mutations are restored even when a downstream handler
cancels the render.
Tests
- JUnit harness with 76+ tests across GlbParserUtils, GltfPoseConverter,
FurnitureSeatGeometry, and FurnitureAuthPredicate.
This commit is contained in:
@@ -81,6 +81,19 @@ public class PlayerDisconnectHandler {
|
||||
// Clean up cell selection mode
|
||||
com.tiedup.remake.cells.CellSelectionManager.cleanup(playerId);
|
||||
|
||||
// NOTE: tiedup_locked_furniture is intentionally NOT cleaned on logout —
|
||||
// it's load-bearing for NetworkEventHandler.handleFurnitureReconnection
|
||||
// (the "disconnect to escape" prevention).
|
||||
//
|
||||
// tiedup_furniture_lockpick_ctx IS cleaned: it's session-ephemeral,
|
||||
// valid only during an active lockpick mini-game. If left stale it
|
||||
// causes PacketLockpickAttempt to mis-route a later body-item
|
||||
// lockpick as a furniture pick and silently return without ending
|
||||
// the session.
|
||||
if (event.getEntity() instanceof net.minecraft.server.level.ServerPlayer serverPlayer) {
|
||||
serverPlayer.getPersistentData().remove("tiedup_furniture_lockpick_ctx");
|
||||
}
|
||||
|
||||
// BUG FIX: Security - Remove labor tools from disconnecting player
|
||||
// This prevents players from keeping unbreakable tools by disconnecting
|
||||
if (
|
||||
|
||||
Reference in New Issue
Block a user